Move all metadata to pyproject.toml #1026
Conversation
floris/__init__.py
Outdated
| from pathlib import Path | ||
|
|
||
|
|
||
| with open(Path(__file__).parent / "version.py") as _version_file: | ||
| __version__ = _version_file.read().strip() | ||
| __version__ = version("flasc") |
There was a problem hiding this comment.
Fixed sorry for that one!
| { name = "Rafael Mudafort", email = "[email protected]" }, | ||
| { name = "Paul Fleming", email = "[email protected]" }, | ||
| { name = "Michael (Misha) Sinner", email = "[email protected]" }, | ||
| { name = "Eric Simley", email = "[email protected]" }, |
| python_requires=REQUIRES_PYTHON, | ||
| url=URL, | ||
| packages=find_packages(exclude=["tests", "*.tests", "*.tests.*", "tests.*"]), | ||
| package_data={ |
There was a problem hiding this comment.
Don't forget about this part
There was a problem hiding this comment.
Good catch, thank you, think I've got it back in
|
@rafmudaf , 3.8 is the only failing test, but 3.8 is also end of life: |
|
Changing the minimum Python version is kind of a big decision, so I wouldn't make that change just because a test is failing. However, whether to support Python 3.8 is a fair question. It may be worth asking for some community input. |
|
In this case, the error is because you specified Python >= 3.9, but the GitHub Actions job is testing Python 3.8. So the fix as it relates to the scope of this pull request is to use |
You're right, think I've fixed this now |
| @@ -20,11 +20,11 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| pip install setuptools wheel twine | |||
| pip install build twine | |||
There was a problem hiding this comment.
I think this is the change that hung us up over on FLASC---presumably as long as thee python -m build line runs below, it should upload to PyPI correctly?
There was a problem hiding this comment.
That's right, I think I've gotten to learn from that and now this should go off fine, easy to test locally too but you don't want to run the twine call
There was a problem hiding this comment.
If you want to fully test it, you could use the TestPyPI instance. If you did that, you could create a release on your fork and see that it uploads correctly without affecting anything on the primary repository.
Also heads up that this pull request is pointing to main rather than develop. Maybe that was intentional, but just pointing it out in case it wasn't.
There was a problem hiding this comment.
Should've been develop, moved over now
|
@paulf81 I was able to pip install this into a new conda environment and ran an example without issue. |
Move all metadata to pyproject.toml
Following examples such as:
https://packaging.python.org/en/latest/guides/modernize-setup-py-project/
This PR moves all metadata into pyproject.toml. Specifically: